Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unmute result type tests and modify TypeError/ValueError tests #1663

Merged
merged 9 commits into from
Feb 8, 2024
Merged

Unmute result type tests and modify TypeError/ValueError tests #1663

merged 9 commits into from
Feb 8, 2024

Conversation

vtavana
Copy link
Collaborator

@vtavana vtavana commented Jan 20, 2024

In this PR, some tests are unmuted or modified since they will pass now since dpctl is updated in Internal CI.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • If this PR is a work in progress, are you filing the PR as a draft?

@vtavana vtavana self-assigned this Jan 20, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 20, 2024 •
edited
Loading

View rendered docs @ https://intelpython.github.io/dpnp/index.html

@vtavana vtavana marked this pull request as draft January 20, 2024 19:21
@vtavana vtavana marked this pull request as ready for review February 3, 2024 21:35
antonwolfy
antonwolfy approved these changes Feb 7, 2024
View reviewed changes
Copy link
Contributor

@antonwolfy antonwolfy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @vtavana so much for handling that!

@vtavana vtavana merged commit 2ce997d into master Feb 8, 2024
45 checks passed
@vtavana vtavana deleted the unmute_result_type_tests branch February 8, 2024 23:40
github-actions bot added a commit that referenced this pull request Feb 9, 2024
@github-actions
Unmute result type tests and modify TypeError/ValueError tests (#1663)
bf510df 
* unmute result type tests

* update TypeError and ValueError tests

* update TestResultType 2ce997d
@antonwolfy antonwolfy mentioned this pull request Feb 10, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@antonwolfy antonwolfy antonwolfy approved these changes

Assignees

@vtavana vtavana

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vtavana @antonwolfy