Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

implement sort and argsort #1660

Merged
merged 6 commits into from
Jan 22, 2024
Merged

implement sort and argsort #1660

merged 6 commits into from
Jan 22, 2024

Conversation

vtavana
Copy link
Collaborator

@vtavana vtavana commented Jan 17, 2024

In this PR, dpnp.sort and dpnp.argsort are implemented using their dcptl counterparts.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • If this PR is a work in progress, are you filing the PR as a draft?

@vtavana vtavana self-assigned this Jan 17, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 17, 2024 •
edited
Loading

View rendered docs @ https://intelpython.github.io/dpnp/pull//index.html

@vtavana vtavana marked this pull request as ready for review January 17, 2024 21:38
vtavana
vtavana commented Jan 17, 2024
View reviewed changes
dpnp/dpnp_iface_sorting.py Outdated Show resolved Hide resolved
antonwolfy
antonwolfy reviewed Jan 19, 2024
View reviewed changes
dpnp/dpnp_iface_sorting.py Outdated Show resolved Hide resolved
dpnp/dpnp_iface_sorting.py Outdated Show resolved Hide resolved
dpnp/dpnp_iface_sorting.py Outdated Show resolved Hide resolved
dpnp/dpnp_array.py Show resolved Hide resolved
dpnp/dpnp_iface_sorting.py Show resolved Hide resolved
tests/third_party/cupy/sorting_tests/test_sort.py Outdated Show resolved Hide resolved
tests/third_party/cupy/sorting_tests/test_sort.py Show resolved Hide resolved
tests/third_party/cupy/sorting_tests/test_sort.py Outdated Show resolved Hide resolved
tests/test_sort.py Outdated Show resolved Hide resolved
tests/test_sort.py Outdated Show resolved Hide resolved
antonwolfy
antonwolfy approved these changes Jan 20, 2024
View reviewed changes
Copy link
Contributor

@antonwolfy antonwolfy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't have more comments, LGTM. Thank you @vtavana

@antonwolfy antonwolfy merged commit 8072622 into master Jan 22, 2024
39 of 45 checks passed
@antonwolfy antonwolfy deleted the sort_argsort branch January 22, 2024 12:33
github-actions bot added a commit to antonwolfy/dpnp that referenced this pull request Jan 22, 2024
@github-actions
implement sort and argsort (IntelPython#1660)
8fe8c1a 
* implement sort and argsort

* add more tests

* update for zero dimensional arrays

* address comments

* fix typo 8072622
@antonwolfy antonwolfy mentioned this pull request Feb 1, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@antonwolfy antonwolfy antonwolfy approved these changes

Assignees

@vtavana vtavana

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vtavana @antonwolfy