Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

re-write exp and log functions #1576

Merged
merged 3 commits into from
Oct 11, 2023
Merged

re-write exp and log functions #1576

merged 3 commits into from
Oct 11, 2023

Conversation

vtavana
Copy link
Collaborator

@vtavana vtavana commented Oct 2, 2023

The PR changes the implementation of dpnp.exp, dpnp.expm1, dpnp.log10, dpnp.log1p, and dpnp.log2. These functions now invoke oneapi::mkl::vm implementation from pybind11 extension of OneMKL VM if possible or uses dpctl.tensor implementation if not.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • If this PR is a work in progress, are you filing the PR as a draft?

@vtavana vtavana self-assigned this Oct 2, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Oct 2, 2023 •
edited
Loading

View rendered docs @ https://intelpython.github.io/dpnp/index.html

@vtavana vtavana marked this pull request as ready for review October 2, 2023 19:14
antonwolfy
antonwolfy reviewed Oct 10, 2023
View reviewed changes
dpnp/backend/extensions/vm/types_matrix.hpp Outdated Show resolved Hide resolved
dpnp/backend/extensions/vm/types_matrix.hpp Outdated Show resolved Hide resolved
tests/test_umath.py Show resolved Hide resolved
dpnp/backend/extensions/vm/types_matrix.hpp Outdated Show resolved Hide resolved
dpnp/backend/extensions/vm/vm_py.cpp Outdated Show resolved Hide resolved
antonwolfy
antonwolfy approved these changes Oct 11, 2023
View reviewed changes
Copy link
Contributor

@antonwolfy antonwolfy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @vtavana

@vtavana vtavana merged commit d4e3e79 into master Oct 11, 2023
33 checks passed
@vtavana vtavana deleted the exp_log_dpctl_to_dpnp branch October 11, 2023 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@antonwolfy antonwolfy antonwolfy approved these changes

@vlad-perevezentsev vlad-perevezentsev Awaiting requested review from vlad-perevezentsev vlad-perevezentsev is a code owner

@npolina4 npolina4 Awaiting requested review from npolina4 npolina4 is a code owner

Assignees

@vtavana vtavana

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vtavana @antonwolfy