Skip to content

Fix gh-1539 #1563

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Sep 25, 2023
Merged

Fix gh-1539 #1563

merged 4 commits into from
Sep 25, 2023

Conversation

npolina4
Copy link
Contributor

closes #1539 dpnp.sum(x, axis=0) is very slow on integral 64-bit types

call dpctl.tensor.sum() function for 64-bit types

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?

@github-actions
Copy link
Contributor

github-actions bot commented Sep 18, 2023

View rendered docs @ https://intelpython.github.io/dpnp/index.html

vlad-perevezentsev

This comment was marked as outdated.

Copy link
Collaborator

@vlad-perevezentsev vlad-perevezentsev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
thanks @npolina4

@vlad-perevezentsev vlad-perevezentsev merged commit 747ef6c into master Sep 25, 2023
@vlad-perevezentsev vlad-perevezentsev deleted the gh-1539 branch September 25, 2023 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

dpnp.sum(x, axis=0) is very slow on integral 64-bit types
2 participants