Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update tests to run on Iris Xe #1498

Merged
merged 5 commits into from
Jul 27, 2023
Merged

Update tests to run on Iris Xe #1498

merged 5 commits into from
Jul 27, 2023

Conversation

npolina4
Copy link
Collaborator

@npolina4 npolina4 commented Jul 25, 2023 •
edited by antonwolfy
Loading

Update random, logic, manipulation, and mixins tests to run on Iris Xe.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • If this PR is a work in progress, are you filing the PR as a draft?

antonwolfy
antonwolfy reviewed Jul 25, 2023
View reviewed changes
tests/test_manipulation.py Outdated Show resolved Hide resolved
tests/test_manipulation.py Outdated Show resolved Hide resolved
tests/test_manipulation.py Outdated Show resolved Hide resolved
tests/test_manipulation.py Outdated Show resolved Hide resolved
tests/test_mixins.py Outdated Show resolved Hide resolved
tests/test_mixins.py Outdated Show resolved Hide resolved
antonwolfy
antonwolfy reviewed Jul 27, 2023
View reviewed changes
tests/test_mixins.py Outdated Show resolved Hide resolved
antonwolfy
antonwolfy approved these changes Jul 27, 2023
View reviewed changes
Copy link
Contributor

@antonwolfy antonwolfy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! thank you @npolina4

@npolina4 npolina4 merged commit 85ea6f9 into master Jul 27, 2023
20 checks passed
@npolina4 npolina4 deleted the iris_xe_test1 branch July 27, 2023 19:22
This was referenced Sep 19, 2023
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@antonwolfy antonwolfy antonwolfy approved these changes

@vlad-perevezentsev vlad-perevezentsev Awaiting requested review from vlad-perevezentsev vlad-perevezentsev is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@npolina4 @antonwolfy