Resolve warning and error with cython 3.0.0 #1495
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antonwolfy
requested review from
oleksandr-pavlyk,
vlad-perevezentsev and
npolina4
antonwolfy
force-pushed
the
enable_cython_v3
branch
from
6883c49 to
a23a15f
Compare
vlad-perevezentsev
approved these changes
Jul 24, 2023
This was referenced Sep 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR resolves compilation error which mainly looks relating to incorrect code generation by cython 3.0.0 in case of any import with asterisk. By the way, all asterisk imports were removed from
dparray.pyx, since it makes the code more clear.Also the PR suppresses a compilation warning caused by the deprecated pre-NumPy-1.7 C-API. The suppression is implemented by defining
-DNPY_NO_DEPRECATED_API=NPY_1_7_API_VERSIONthrough cmake following the cython recommendation.Remaining warnings are caused by either dpctl or cython issues.
The PR removes temporary pining to cython "<3" in the receipt and from actions, since all issues are resolved.