Skip to content

Continue parallel uploading in case of error #1466

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 6, 2023

Conversation

antonwolfy
Copy link
Contributor

@antonwolfy antonwolfy commented Jul 5, 2023

The PR proposes to permit parallel uploading to conda even if any single upload job fails.

It might be a case when uploading of any built conda package is failed due to some connectivity issue and it would be enough to rerun it. But with option continue-on-error: false all other running upload jobs will be cancelled due to that.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • If this PR is a work in progress, are you filing the PR as a draft?

@antonwolfy antonwolfy self-assigned this Jul 5, 2023
@antonwolfy antonwolfy merged commit b240844 into master Jul 6, 2023
@antonwolfy antonwolfy deleted the continue_upload_on_error branch July 6, 2023 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant