Adds a new github CI Action to generate coverage and upload to coveralls #1373
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vlad-perevezentsev
force-pushed
the
add_gen_coverage
branch
from
6be41f1
to
cd18e17
Compare
vlad-perevezentsev
force-pushed
the
add_gen_coverage
branch
from
cd18e17
to
a9d7906
Compare
antonwolfy
reviewed
Apr 7, 2023
| - name: Build dpnp with coverage | ||
| run: | | ||
| python scripts/gen_coverage.py --pytest-opts="--ignore tests/test_random.py \ | ||
| --ignore tests/test_strides.py" |
There was a problem hiding this comment.
Probably it would be good to have a separate variable with a list of ignoring tests.
antonwolfy
reviewed
Apr 7, 2023
| @@ -1,6 +1,6 @@ | |||
| import math | |||
| import pytest | |||
| from .helper import get_all_dtypes | |||
| from .helper import get_all_dtypes, is_cpu_device | |||
There was a problem hiding this comment.
I guess the change is not needed anymore.
Use `sys.executable` instead of `"python"` in `check_output` call
|
I think this can be merged now, especially given that it is being merged to another branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new script
gen_coverage.pyto build dpnp develop with coverage paraments and generate coverage reports.Also adds
generate_coverage.yamlto run the build on GitHub Action and upload reports to coveralls.io