Skip to content

Support more use cases for 'out' parameter #1341

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 31, 2023

Conversation

antonwolfy
Copy link
Contributor

@antonwolfy antonwolfy commented Mar 16, 2023

The PR is about to improve handling of out parameter in supported dpnp functions.
It's required to consider use cases when

  • out refers to the same array as any of input ones
  • out with strides
  • out where dtype is different from expected one

In both cases extra memory is allocated and it's need to copy the result back from temporary array into out array.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • If this PR is a work in progress, are you filing the PR as a draft?

@antonwolfy antonwolfy self-assigned this Mar 16, 2023
Copy link
Collaborator

@vlad-perevezentsev vlad-perevezentsev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job!

@vlad-perevezentsev vlad-perevezentsev dismissed their stale review March 17, 2023 14:25

This PR is not completed yet

@vlad-perevezentsev vlad-perevezentsev self-requested a review March 23, 2023 18:41
Copy link
Collaborator

@vlad-perevezentsev vlad-perevezentsev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants