Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support out parameter in dpnp.sqrt() #1332

Merged
merged 7 commits into from
Apr 5, 2023
Merged

Support out parameter in dpnp.sqrt() #1332

merged 7 commits into from
Apr 5, 2023

Conversation

vlad-perevezentsev
Copy link
Collaborator

This PR adds support of out in-place parameter for dpnp.sqrt() function and covers the new implementation by tests.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • If this PR is a work in progress, are you filing the PR as a draft?

@vlad-perevezentsev vlad-perevezentsev self-assigned this Mar 6, 2023
antonwolfy
antonwolfy reviewed Mar 9, 2023
View reviewed changes
dpnp/dpnp_iface_trigonometric.py Outdated Show resolved Hide resolved
dpnp/dpnp_iface_trigonometric.py Outdated Show resolved Hide resolved
dpnp/dpnp_iface_trigonometric.py Outdated Show resolved Hide resolved
tests/test_umath.py Show resolved Hide resolved
dpnp/dpnp_iface_trigonometric.py Outdated Show resolved Hide resolved
@npolina4
Copy link
Collaborator

npolina4 commented Apr 4, 2023

Works in dpbench.

antonwolfy
antonwolfy approved these changes Apr 5, 2023
View reviewed changes
dpnp/dpnp_iface_trigonometric.py Outdated Show resolved Hide resolved
@vlad-perevezentsev @antonwolfy
Fix remark
be3f57f 
Co-authored-by: Anton <100830759+antonwolfy@users.noreply.github.com>
@vlad-perevezentsev vlad-perevezentsev merged commit c389b9d into IntelPython:master Apr 5, 2023
@antonwolfy antonwolfy mentioned this pull request Apr 11, 2023
Closed
antonwolfy pushed a commit that referenced this pull request Jun 6, 2023
@vlad-perevezentsev @antonwolfy
Support out parameter in dpnp.sqrt() (#1332)
70e4263 
* Add support out parameter in dpnp.sqrt()
@vlad-perevezentsev vlad-perevezentsev deleted the inplace_out_dpnp_sqrt branch August 10, 2023 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@antonwolfy antonwolfy antonwolfy approved these changes

@oleksandr-pavlyk oleksandr-pavlyk Awaiting requested review from oleksandr-pavlyk

Assignees

@vlad-perevezentsev vlad-perevezentsev

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vlad-perevezentsev @npolina4 @antonwolfy