Skip to content

Support parameter out in dpnp.add() #1329

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Apr 3, 2023
Merged

Support parameter out in dpnp.add() #1329

merged 10 commits into from
Apr 3, 2023

Conversation

antonwolfy
Copy link
Contributor

@antonwolfy antonwolfy commented Mar 5, 2023 •
edited
Loading

The PR implements support of out in-place parameter for dpnp.add function.
Additionally __iadd__ function of dpnp_array class is added.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • If this PR is a work in progress, are you filing the PR as a draft?

@antonwolfy antonwolfy self-assigned this Mar 5, 2023
vlad-perevezentsev
vlad-perevezentsev reviewed Mar 6, 2023
View reviewed changes
npolina4
npolina4 reviewed Mar 6, 2023
View reviewed changes
vlad-perevezentsev
vlad-perevezentsev reviewed Mar 6, 2023
View reviewed changes
antonwolfy and others added 3 commits March 9, 2023 12:14
@antonwolfy @vlad-perevezentsev
Update tests/test_mathematical.py
857f4c4 
Co-authored-by: vlad-perevezentsev <vladislav.perevezentsev@intel.com>
@antonwolfy @vlad-perevezentsev
Update tests/test_mathematical.py
b0e40b1 
Co-authored-by: vlad-perevezentsev <vladislav.perevezentsev@intel.com>
@antonwolfy
Merge branch 'master' into inplace_add
5302115
antonwolfy
antonwolfy commented Mar 9, 2023
View reviewed changes
@antonwolfy antonwolfy merged commit d41ed51 into IntelPython:master Apr 3, 2023
@antonwolfy antonwolfy deleted the inplace_add branch April 3, 2023 09:36
@antonwolfy antonwolfy mentioned this pull request Apr 11, 2023
Closed
antonwolfy added a commit that referenced this pull request Jun 6, 2023
@antonwolfy @vlad-perevezentsev @npolina4
Support parameter out in dpnp.add() (#1329)
c62b9ac 
* Suppport parameter out in dpnp.add()

* Update tests/test_mathematical.py

Co-authored-by: vlad-perevezentsev <vladislav.perevezentsev@intel.com>

* Update tests/test_mathematical.py

Co-authored-by: vlad-perevezentsev <vladislav.perevezentsev@intel.com>

* Update tests/test_mathematical.py

* Update tests/test_mathematical.py

Co-authored-by: Natalia Polina <natalia.polina@intel.com>

* Use internal _check_nd_call() function which is common for mathematical ones with 2 input arrays

* Add more test for 'out' parameter

---------

Co-authored-by: vlad-perevezentsev <vladislav.perevezentsev@intel.com>
Co-authored-by: Natalia Polina <natalia.polina@intel.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vlad-perevezentsev vlad-perevezentsev vlad-perevezentsev left review comments

@npolina4 npolina4 npolina4 approved these changes

@oleksandr-pavlyk oleksandr-pavlyk Awaiting requested review from oleksandr-pavlyk

Assignees

@antonwolfy antonwolfy

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@antonwolfy @vlad-perevezentsev @npolina4