-
Notifications
You must be signed in to change notification settings - Fork 22
Use linspace() function from dpctl.tensor. #1281
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
My experiment that ran into an error:
A variation I should also note that When the array support works, it is rather slow. It would be nice to understand why.
|
|
_start = dpnp.asarray(start, dtype=dt, usm_type=usm_type, sycl_queue=sycl_queue_normalized) | ||
_stop = dpnp.asarray(stop, dtype=dt, usm_type=usm_type, sycl_queue=sycl_queue_normalized) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In case start
and stop
are both dpnp_array
or usm_ndarray
, we might change usm_type
type here for resulting _start
and _stop
and so zero copy will not be applied (i.e. extra memory copy might take place).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! LGMT!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @npolina4 !
The PR is going to resolve issue #1249 . |
Co-authored-by: Oleksandr Pavlyk <oleksandr.pavlyk@intel.com>
Use linspace() function from dpctl.tensor module instead of DPNP backend implementation.