Extend backend functions interfaces with queue and events#1122
Merged
Alexander-Makaryev merged 8 commits intoIntelPython:masterfrom Feb 18, 2022
Merged
Extend backend functions interfaces with queue and events#1122Alexander-Makaryev merged 8 commits intoIntelPython:masterfrom
Alexander-Makaryev merged 8 commits intoIntelPython:masterfrom
Conversation
densmirn
requested review from
Alexander-Makaryev,
KsanaKozlova and
LukichevaPolina
Contributor
|
For some reason tests on Windows become extremely slow on this PR. We need to pay attention on this during next iterations of testing. |
Alexander-Makaryev
approved these changes
Feb 18, 2022
Comment on lines
+531
to
+533
| * @param [out] result1 Output array. | ||
| * @param [in] size Number of elements in input arrays. | ||
| * @param [in] dep_event_vec_ref Reference to vector of SYCL events. |
Contributor
There was a problem hiding this comment.
Suggested change
| * @param [out] result1 Output array. | |
| * @param [in] size Number of elements in input arrays. | |
| * @param [in] dep_event_vec_ref Reference to vector of SYCL events. | |
| * @param [out] result1 Output array. | |
| * @param [in] size Number of elements in input arrays. | |
| * @param [in] dep_event_vec_ref Reference to vector of SYCL events. |
Comment on lines
+550
to
552
| * @param [in] q_ref Reference to SYCL queue. | ||
| * @param [out] result_out Output array. | ||
| * @param [in] result_size Size of output array. |
Contributor
There was a problem hiding this comment.
Suggested change
| * @param [in] q_ref Reference to SYCL queue. | |
| * @param [out] result_out Output array. | |
| * @param [in] result_size Size of output array. | |
| * @param [in] q_ref Reference to SYCL queue. | |
| * @param [out] result_out Output array. | |
| * @param [in] result_size Size of output array. |
Comment on lines
+514
to
+521
| _DataType* min_arr = reinterpret_cast<_DataType*>(sycl::malloc_shared(result_size * sizeof(_DataType), q)); | ||
| _DataType* max_arr = reinterpret_cast<_DataType*>(sycl::malloc_shared(result_size * sizeof(_DataType), q)); | ||
|
|
||
| dpnp_min_c<_DataType>(arr, min_arr, result_size, input_shape, input_ndim, axis, naxis); | ||
| dpnp_max_c<_DataType>(arr, max_arr, result_size, input_shape, input_ndim, axis, naxis); | ||
|
|
||
| shape_elem_type* _strides = | ||
| reinterpret_cast<shape_elem_type*>(dpnp_memory_alloc_c(result_ndim * sizeof(shape_elem_type))); | ||
| reinterpret_cast<shape_elem_type*>(sycl::malloc_shared(result_ndim * sizeof(shape_elem_type), q)); |
Contributor
There was a problem hiding this comment.
The question to think about...
Do we really want to stop using functions like dpnp_memory_alloc_c and dpnp_memory_free_c?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.