Skip to content

Use pin-compatible dpcpp-cpp-rt to restrict range of dpcpp-cpp-rt #986

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 10, 2022

Conversation

oleksandr-pavlyk
Copy link
Contributor

This ensures that dpctl built with 2023 compiler
can be installed into 2022 environment, as they are ABI incompatible

With this change, dpctl will have dependency depending on the version of the compiler used during building.

If building with 2023, we are going to have

dependencies:
  - dpcpp-cpp-rt >=2023.0,<2024.0a0
  • Have you provided a meaningful PR description?

antonwolfy
antonwolfy previously approved these changes Nov 10, 2022
@github-actions
Copy link

@coveralls
Copy link
Collaborator

coveralls commented Nov 10, 2022

Coverage Status

Coverage remained the same at 81.978% when pulling c8d9aee on use-compatible-dpcpp-rt into a2a62dc on master.

@oleksandr-pavlyk
Copy link
Contributor Author

For some reason, building for python 3.10, conda build does not generate dependency for dpcpp-cpp-rt at all:

(base) user@user-mobl:~/work $ conda search -c ~/local_channel/ dpctl=0.14.0rc1 --override-channels --info
Loading channels: done
dpctl 0.14.0rc1 py310h8c27c75_3
-------------------------------
file name   : dpctl-0.14.0rc1-py310h8c27c75_3.tar.bz2
name        : dpctl
version     : 0.14.0rc1
build       : py310h8c27c75_3
build number: 3
size        : 2.6 MB
license     : Apache-2.0
subdir      : linux-64
url         : file:///home/user/local_channel/linux-64/dpctl-0.14.0rc1-py310h8c27c75_3.tar.bz2
md5         : c9148aa2958dedaab42373b8ad2ddc74
timestamp   : 2022-11-10 19:23:55 UTC
dependencies:
  - dpcpp-cpp-rt
  - libgcc-ng >=11.2.0
  - libstdcxx-ng >=11.2.0
  - numpy >=1.21,<2.0a0
  - python >=3.10,<3.11.0a0


dpctl 0.14.0rc1 py39h8c27c75_3
------------------------------
file name   : dpctl-0.14.0rc1-py39h8c27c75_3.tar.bz2
name        : dpctl
version     : 0.14.0rc1
build       : py39h8c27c75_3
build number: 3
size        : 2.6 MB
license     : Apache-2.0
subdir      : linux-64
url         : file:///home/user/local_channel/linux-64/dpctl-0.14.0rc1-py39h8c27c75_3.tar.bz2
md5         : a07d41b6bdf85b671b9858a2bead0c6c
timestamp   : 2022-11-10 19:25:07 UTC
dependencies:
  - dpcpp-cpp-rt >=2022.2,<2023.0a0
  - libgcc-ng >=11.2.0
  - libstdcxx-ng >=11.2.0
  - numpy >=1.21,<2.0a0
  - python >=3.9,<3.10.0a0

Must be a bug in conda build.

Keeping this open until root-cause is identified.

This ensures that dpctl built with 2023 compiler
can be installed into 2022 environment, as they are ABI incompatible
@github-actions
Copy link

Array API standard conformance tests for dpctl=0.14.0rc1=py310h8c27c75_6 ran successfully.
Passed: 33
Failed: 801
Skipped: 3138

@github-actions
Copy link

Array API standard conformance tests for dpctl=0.14.0rc1=py310h8c27c75_5 ran successfully.
Passed: 33
Failed: 801
Skipped: 3138

@oleksandr-pavlyk oleksandr-pavlyk merged commit 78d94aa into master Nov 10, 2022
@oleksandr-pavlyk oleksandr-pavlyk deleted the use-compatible-dpcpp-rt branch November 10, 2022 23:36
@github-actions
Copy link

Deleted rendered PR docs from intelpython.github.com/dpctl, latest should be updated shortly. 🤞

@github-actions
Copy link

Array API standard conformance tests for dpctl=0.14.0rc1=py310h8c27c75_19 ran successfully.
Passed: 33
Failed: 801
Skipped: 3138

@github-actions
Copy link

Array API standard conformance tests for dpctl=0.14.0rc2=py310h8c27c75_0 ran successfully.
Passed: 32
Failed: 802
Skipped: 3138

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants