-
Notifications
You must be signed in to change notification settings - Fork 30
Added support for arrays for fill_value for full() function #982
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
View rendered docs @ https://intelpython.github.io/dpctl/pulls/982/index.html |
Array API standard conformance tests for dpctl=0.14.0dev1=py310h8c27c75_57 ran successfully. |
Array API standard conformance tests for dpctl=0.14.0dev1=py310h8c27c75_58 ran successfully. |
dpctl/tensor/_ctors.py
Outdated
X = dpt.asarray( | ||
fill_value, | ||
dtype=dtype, | ||
device=device, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
device=device, |
Since normalize_queue_device
has been called, we only need to use sycl_queue
argument.
More tests are needed. Check support for working with 0d arrays, e.g.
|
Array API standard conformance tests for dpctl=0.14.0rc2=py310h8c27c75_8 ran successfully. |
…/dpctl into fix_full_array_dtype
Array API standard conformance tests for dpctl=0.14.0rc2=py310h8c27c75_12 ran successfully. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @npolina4 !
This looks great. Let's wait for the CI and merge.
Deleted rendered PR docs from intelpython.github.com/dpctl, latest should be updated shortly. 🤞 |
Array API standard conformance tests for dpctl=0.14.0rc2=py310h8c27c75_14 ran successfully. |
Added support for numpy.ndarray and dpctl.tensor.usm_ndarray for fill_value for dpctl.tensor.full() function.