-
Notifications
You must be signed in to change notification settings - Fork 30
Fix/issue 83 #96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Fix/issue 83 #96
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…fo::device_type>().
-- Queues now need to be queried using both backend and device type. -- Fix test cases. -- Platform interfaces now can return the list of available backends. -- Fix skiped tests. -- Expand the platform interface to provide backend info. -- Move backend enums to platfrom from context. -- Add comments. -- Store opencl_cpu, opencl_gpu, and level0_gpu queues inside queue manager. -- Fixed enum typedefs, added cython dict to store backends and device types.
About static variables.
- Rename SyclQueueManager to SyclRTManager - Minor stylistic changes: -- reorder functions alphabetically. -- Move all enums into separate file. - Add C API to get backend from queue, and also add a way to check if a queue is the current queue. - Update sycl_core to match C API.
-- Added a way to check if two DPPLSyclQueueRef and the SyclQueue wrappers point to the same sycl queue. -- Same thing for DPPLSyclContextRef and SyclContext.
-- default device is alayws available.
-- default device is always available.
PokhodenkoSA
approved these changes
Oct 5, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Solution is not to create context on devices that are not of the requested device type or not from the requested backend. ``` Python 3.7.7 (default, Jul 14 2020, 22:02:37) Type 'copyright', 'credits' or 'license' for more information IPython 7.17.0 -- An enhanced Interactive Python. Type '?' for help. In [1]: import dpctl In [2]: with dpctl.device_context('opencl:gpu'): ...: print(1) ...: 1 In [3]: with dpctl.device_context('level0:gpu'): ...: print(1) ...: 1 ```
…rupd/dpctl into feature/backend_specific_queues_v2
* CC=clang.exe * CC=clang-cl.exe
* CC=clang.exe * CC=clang-cl.exe
…ific_queues_v2 Feature/backend specific queues v2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #83