Skip to content

Fix/issue 83 #96

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 34 commits into from
Oct 5, 2020
Merged

Fix/issue 83 #96

merged 34 commits into from
Oct 5, 2020

Conversation

diptorupd
Copy link
Contributor

Closes #83

Diptorup Deb and others added 23 commits October 3, 2020 11:07
   -- Queues now need to be queried using both backend and device type.
   -- Fix test cases.
   -- Platform interfaces now can return the list of available backends.
   -- Fix skiped tests.
   -- Expand the platform interface to provide backend info.
   -- Move backend enums to platfrom from context.
   -- Add comments.
   -- Store opencl_cpu, opencl_gpu, and level0_gpu queues inside queue manager.
   -- Fixed enum typedefs, added cython dict to store backends and device types.
About static variables.
     - Rename SyclQueueManager to SyclRTManager
     - Minor stylistic changes:
          -- reorder functions alphabetically.
	  -- Move all enums into separate file.
     - Add C API to get backend from queue,
       and also add a way to check if a queue is the current queue.
     - Update sycl_core to match C API.
    -- Added a way to check if two DPPLSyclQueueRef and the SyclQueue
       wrappers point to the same sycl queue.
    -- Same thing for DPPLSyclContextRef and SyclContext.
Copy link
Contributor

@PokhodenkoSA PokhodenkoSA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For 1de7ff4 - LGTM.
Other commits as I understand are from #93.

oleksandr-pavlyk and others added 4 commits October 5, 2020 10:58
Solution is not to create context on devices that are not
of the requested device type or not from the requested backend.

```
Python 3.7.7 (default, Jul 14 2020, 22:02:37)
Type 'copyright', 'credits' or 'license' for more information
IPython 7.17.0 -- An enhanced Interactive Python. Type '?' for help.

In [1]: import dpctl

In [2]: with dpctl.device_context('opencl:gpu'):
   ...:     print(1)
      ...:
      1

In [3]: with dpctl.device_context('level0:gpu'):
   ...:     print(1)
      ...:
      1

```
…rupd/dpctl into feature/backend_specific_queues_v2
@diptorupd diptorupd merged commit 7f7b090 into IntelPython:master Oct 5, 2020
@diptorupd diptorupd deleted the fix/issue_83 branch October 5, 2020 22:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

We need to support ctypes uint8 and ulong
3 participants