Skip to content

Use error_handler if getSymbol encountered error and returns nullptr #956

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 2, 2022

Conversation

oleksandr-pavlyk
Copy link
Contributor

This PR adds call to error_handler into the branch of DynamicLibHelper::getSymbol where it returns nullptr because of an error,

  • Have you provided a meaningful PR description?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?

@oleksandr-pavlyk oleksandr-pavlyk force-pushed the use-error-handle-in-getSymbol branch from 4692f4e to f24aa12 Compare November 1, 2022 14:23
@github-actions
Copy link

github-actions bot commented Nov 1, 2022

@coveralls
Copy link
Collaborator

Coverage Status

Coverage decreased (-0.02%) to 82.033% when pulling f24aa12 on use-error-handle-in-getSymbol into 36c8f71 on master.

@github-actions
Copy link

github-actions bot commented Nov 1, 2022

Array API standard conformance tests for dpctl=0.14.0dev0=py310h8c27c75_228 ran successfully.
Passed: 33
Failed: 801
Skipped: 3138

1 similar comment
@github-actions
Copy link

github-actions bot commented Nov 1, 2022

Array API standard conformance tests for dpctl=0.14.0dev0=py310h8c27c75_228 ran successfully.
Passed: 33
Failed: 801
Skipped: 3138

@oleksandr-pavlyk oleksandr-pavlyk merged commit 85ec499 into master Nov 2, 2022
@oleksandr-pavlyk oleksandr-pavlyk deleted the use-error-handle-in-getSymbol branch November 2, 2022 11:45
@github-actions
Copy link

github-actions bot commented Nov 2, 2022

Deleted rendered PR docs from intelpython.github.com/dpctl, latest should be updated shortly. 🤞

@github-actions
Copy link

github-actions bot commented Nov 2, 2022

Array API standard conformance tests for dpctl=0.14.0dev0=py310h8c27c75_230 ran successfully.
Passed: 33
Failed: 801
Skipped: 3138

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants