Moved implementation of kernels out to dedicated header files. #925
Conversation
|
This PR is the first step to be merged to |
|
View rendered docs @ https://intelpython.github.io/dpctl/pulls/925/index.html |
|
Array API standard conformance tests failed to run for dpctl=0.14.0dev0=py310h8c27c75_146. |
|
Array API standard conformance tests failed to run for dpctl=0.14.0dev0=py310h8c27c75_147. |
|
Array API standard conformance tests failed to run for dpctl=0.14.0dev0=py310h8c27c75_148. |
|
@oleksandr-pavlyk A general comment is regarding the documentation of the code. As these kernels can potentially be used outside of dpctl, we definitely need docstrings and API docs generated. |
|
Yes, I will add it, but it would be best to do it in a separate PR to the target branch. I want to check in other pending changes which I have restructured into separate commits. |
oleksandr-pavlyk
force-pushed
the
cleanup-tensor-py
branch
from
f7ac1c5 to
49acfa1
Compare
|
Array API standard conformance tests for dpctl=0.14.0dev0=py310h8c27c75_167 ran successfully. |
This is to avoid multiple definitions compilation error when using multiple translation units.
…efinition of' compilation error messages
oleksandr-pavlyk
force-pushed
the
cleanup-tensor-py
branch
from
49acfa1 to
34bfc6d
Compare
|
Array API standard conformance tests for dpctl=0.14.0dev0=py310h8c27c75_169 ran successfully. |
|
Array API standard conformance tests for dpctl=0.14.0dev0=py310h8c27c75_170 ran successfully. |
|
@diptorupd I have pushed changes adding doxygen docstrings for exported templated |
|
Deleted rendered PR docs from intelpython.github.com/dpctl, latest should be updated shortly. 🤞 |
This PR moves out implementations of implementation kernels into separate header files.
This PR is the first of the series of smaller PRs separated from #923.