Skip to content

Fix bugs highlighted by tools #92

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Oct 6, 2020
Merged

Fix bugs highlighted by tools #92

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
6ce4df9
Fix unhandled character
PokhodenkoSA Oct 3, 2020
fb6ad3b
Fix unhandled character
PokhodenkoSA Oct 3, 2020
c5f2a47
Remove unused imports
PokhodenkoSA Oct 3, 2020
b9d1dcb
Fix class name duplication
PokhodenkoSA Oct 3, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion backends/include/dppl_sycl_usm_interface.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,6 +84,6 @@ void DPPLfree_with_context (__dppl_take DPPLSyclUSMRef MRef,
DPPL_API
const char *
DPPLUSM_GetPointerType (__dppl_keep const DPPLSyclUSMRef MRef,
__dppl_keep const DPPLSyclContextRef СRef);
__dppl_keep const DPPLSyclContextRef CRef);

DPPL_C_EXTERN_C_END
4 changes: 2 additions & 2 deletions backends/source/dppl_sycl_usm_interface.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,10 +73,10 @@ void DPPLfree_with_queue (__dppl_take DPPLSyclUSMRef MRef,
}

void DPPLfree_with_context (__dppl_take DPPLSyclUSMRef MRef,
__dppl_keep const DPPLSyclContextRef СRef)
__dppl_keep const DPPLSyclContextRef CRef)
{
auto Ptr = unwrap(MRef);
auto C = unwrap(СRef);
auto C = unwrap(CRef);
free(Ptr, *C);
}

Expand Down
1 change: 0 additions & 1 deletion dpctl/tests/test_dump_functions.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,6 @@
import unittest

import dpctl
import dpctl.ocldrv as drv


class TestDumpMethods(unittest.TestCase):
Expand Down
4 changes: 2 additions & 2 deletions dpctl/tests/test_sycl_queue_manager.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,7 @@ def test_is_in_device_context_inside_nested_device_ctxt (self):


@unittest.skipIf(not dpctl.has_sycl_platforms(), "No SYCL platforms available")
class TestIsInDeviceContext (unittest.TestCase):
class TestGetCurrentDevice (unittest.TestCase):

def test_get_current_device_type_outside_device_ctxt (self):
self.assertNotEqual(dpctl.get_current_device_type(), None)
Expand Down Expand Up @@ -142,7 +142,7 @@ def test_num_current_queues_inside_with_clause (self):
dpctl.has_cpu_queues(), "No OpenCL CPU queues available"
)
def test_num_current_queues_inside_threads (self):
from threading import Thread, local
from threading import Thread
def SessionThread (self):
self.assertEqual(dpctl.get_num_activated_queues(), 0)
with dpctl.device_context("opencl:gpu:0"):
Expand Down