Skip to content

Fixed issue #890 in reshape() function. #915

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 7, 2022
Merged

Conversation

npolina4
Copy link
Contributor

@npolina4 npolina4 commented Sep 21, 2022

Added support for uppercase and lowercase letters for order argument to reshape() function.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to an issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • If this PR is a work in progress, are you filing the PR as a draft?

@npolina4 npolina4 marked this pull request as ready for review September 21, 2022 22:25
@github-actions
Copy link

@coveralls
Copy link
Collaborator

coveralls commented Sep 21, 2022

Coverage Status

Coverage increased (+0.002%) to 82.003% when pulling b54d783 on fix_issue_890 into 7b368a1 on master.

@github-actions
Copy link

Array API standard conformance tests failed to run for dpctl=0.14.0dev0=py310h8c27c75_120.

@github-actions
Copy link

github-actions bot commented Oct 5, 2022

Array API standard conformance tests failed to run for dpctl=0.14.0dev0=py310h8c27c75_144.

Copy link
Contributor

@oleksandr-pavlyk oleksandr-pavlyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you @npolina4

@oleksandr-pavlyk oleksandr-pavlyk merged commit 45d0fb4 into master Oct 7, 2022
@oleksandr-pavlyk oleksandr-pavlyk deleted the fix_issue_890 branch October 7, 2022 20:31
@github-actions
Copy link

github-actions bot commented Oct 7, 2022

Deleted rendered PR docs from intelpython.github.com/dpctl, latest should be updated shortly. 🤞

@github-actions
Copy link

github-actions bot commented Oct 7, 2022

Array API standard conformance tests failed to run for dpctl=0.14.0dev0=py310h8c27c75_144.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants