Replaced deprecated cl::sycl namespace with sycl #898
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
View rendered docs @ https://intelpython.github.io/dpctl/pulls/898/index.html |
diptorupd
previously approved these changes
Sep 7, 2022
There was a problem hiding this comment.
Please move the changes to sycl_function.cpp and examples/cython/sycl_direct_linkage/_buffer_example.pyx to a separate commit.
Otherwise LGTM!
oleksandr-pavlyk
force-pushed
the
remove-deprecations
branch
from
d0fafce to
e68fdc6
Compare
Removed use of deprecated `sycl::info::device::profiling` from `print_device_info` function. Removed `DPCTLDevice_IsUnifiedHostMemory` which was DPCTL interface to deprecated `info::device::host_unified_memory` descriptor now that aspects are implemented.
The function now gets execution queue by value rather than by reference. This is the recommended usage since ``sycl::queue`` is implemented as a shared pointer.
oleksandr-pavlyk
force-pushed
the
remove-deprecations
branch
from
e68fdc6 to
5dfa07c
Compare
|
Deleted rendered PR docs from intelpython.github.com/dpctl, latest should be updated shortly. 🤞 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Building
dpctlwith intel/llvm DPC++ compiler one can seeThis PR removes use of
cl::syclnamespace in favor of recommendedsyclnamespace.This PR also removes use of
sycl::info::device::profiledeprecated descriptor fromprint_device_infofunction, and removedDPCTLDevice_IsUnifiedHostMemoryfunction exposing deprecated descriptorsycl::info::device::host_unified_memory.Open source compiler now compiles the code without deprecation warnings.