Linspace should not use double type unconditionally #878
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… does not support it
… for DP Routine to copy NumPy array to USM array casts double to single precision on host is sycl device does not support double precision
|
View rendered docs @ https://intelpython.github.io/dpctl/pulls/878/index.html |
oleksandr-pavlyk
deleted the
linspace-should-not-use-double-type-unconditionally
branch
|
Deleted rendered PR docs from intelpython.github.com/dpctl, latest should be updated shortly. 🤞 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The kernel implementing
dpctl.tensor.linspaceusesdoubleprecision temporary variable causing issues when running on HW without double precision support.This PR changes the kernel to use
floattype on such hardware.It also changes how copying of double precision numpy array to device w/o DP HW support works.
The array is cast to single precision on host before kernel is launched.
Tests are modified so that test suite now passes on Iris Xe integrated card.