Skip to content

Updated pybind11 from 2.9.2 to 2.10.0 #874

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 6, 2022

Conversation

ndgrigorian
Copy link
Collaborator

@ndgrigorian ndgrigorian commented Aug 3, 2022

This PR updates pybind11 from 2.9.2 to 2.10.0

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to an issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • If this PR is a work in progress, are you filing the PR as a draft?

@coveralls
Copy link
Collaborator

coveralls commented Aug 3, 2022

Coverage Status

Coverage increased (+0.04%) to 81.859% when pulling 79872a0 on ndgrigorian:pybind11-update into da1bf68 on IntelPython:master.

@oleksandr-pavlyk
Copy link
Contributor

Thank you @ndgrigorian This is great.

v2.10.0 does contain the changes needed to simplify code for some type casters in dpctl4pybind11.hpp.

Please leave this PR open for a little while to allow such changes to be tested.

oleksandr-pavlyk and others added 2 commits August 6, 2022 15:25
Used fix contributed to pybind11 that is part of pybind11 2.10 release
Simplified impl of tensor::usm_ndarray and memory::usm_memory classes
Copy link
Contributor

@oleksandr-pavlyk oleksandr-pavlyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you @ndgrigorian

@oleksandr-pavlyk oleksandr-pavlyk merged commit 09de29b into IntelPython:master Aug 6, 2022
@ndgrigorian ndgrigorian deleted the pybind11-update branch August 12, 2022 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants