Skip to content

Getter functions for usm_ndarray are marked const per gh-852 #860

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 24, 2022
Merged

Getter functions for usm_ndarray are marked const per gh-852 #860

merged 1 commit into from
Jul 24, 2022

Conversation

oleksandr-pavlyk
Copy link
Contributor

Closes gh-852.

Getter methods of dpctl::tensor::usm_ndarray class are marked as const.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to an issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • If this PR is a work in progress, are you filing the PR as a draft?

@github-actions
Copy link

View rendered docs @ https://intelpython.github.io/dpctl/pulls/860/index.html

@coveralls
Copy link
Collaborator

Coverage Status

Coverage remained the same at 81.611% when pulling 3785914 on fix/gh-852-const-version into 21f6f12 on master.

@oleksandr-pavlyk oleksandr-pavlyk merged commit f45710f into master Jul 24, 2022
@oleksandr-pavlyk oleksandr-pavlyk deleted the fix/gh-852-const-version branch July 24, 2022 19:59
@github-actions
Copy link

Deleted rendered PR docs from intelpython.github.com/dpctl, latest should be updated shortly. 🤞

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@diptorupd diptorupd Awaiting requested review from diptorupd

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

usm_ndarray should provide const versions of member functions
2 participants
@oleksandr-pavlyk @coveralls