Skip to content

[FIX] versioneer 0.21 regression fixed in vendored file #784

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 28, 2022

Conversation

oleksandr-pavlyk
Copy link
Contributor

This change makes changes to the versioneer.py installed into the codebase.

Versioneer 0.21 added escape character to the match option of git
describe.

  • FIX: Escape asterisk in git describe call on Windows, see python-versionseer/python-versioneer#262

Similar change was made upstream too:

https://github.com/python-versioneer/python-versioneer/pull/283/files

but it has been made it into the released version yet.

(base) C:\Users\opavlyk\devel\dpctl>git describe --tags --dirty --always --long --match "\*"
3bd37749

(base) C:\Users\opavlyk\devel\dpctl>git describe --tags --dirty --always --long --match "\\*"
3bd37749

(base) C:\Users\opavlyk\devel\dpctl>git describe --tags --dirty --always --long --match "*"
0.12.0dev3-33-g3bd37749

Versioneer 0.20 added escape character to the match option of git
describe

```
(base) C:\Users\opavlyk\devel\dpctl>git describe --tags --dirty --always --long --match "\*"
3bd37749

(base) C:\Users\opavlyk\devel\dpctl>git describe --tags --dirty --always --long --match "\\*"
3bd37749

(base) C:\Users\opavlyk\devel\dpctl>git describe --tags --dirty --always --long --match "*"
0.12.0dev3-33-g3bd37749
```
@oleksandr-pavlyk oleksandr-pavlyk changed the title versioneer 0.20 regression fixed versioneer 0.21 regression fixed in vendored file Feb 28, 2022
@github-actions
Copy link

@coveralls
Copy link
Collaborator

coveralls commented Feb 28, 2022

Coverage Status

Coverage remained the same at 81.632% when pulling 78f6369 on fix-versioneer-escape-windows into 335fb23 on master.

@oleksandr-pavlyk oleksandr-pavlyk changed the title versioneer 0.21 regression fixed in vendored file [FIX] versioneer 0.21 regression fixed in vendored file Feb 28, 2022
@oleksandr-pavlyk oleksandr-pavlyk merged commit ca46ad2 into master Feb 28, 2022
@github-actions
Copy link

Deleted rendered PR docs from intelpython.github.com/dpctl, latest should be updated shortly. 🤞

oleksandr-pavlyk added a commit that referenced this pull request Feb 28, 2022
@oleksandr-pavlyk oleksandr-pavlyk deleted the fix-versioneer-escape-windows branch February 28, 2022 22:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants