Only call PyThread_Ensure from host_task if the main-thread interpreter is initialized #776
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oleksandr-pavlyk
changed the title
oleksandr-pavlyk
force-pushed
the
fix-crash-in-async-dec-ref
branch
from
5f235d9 to
76f0f65
Compare
This PR applies the solution worked out in a toy POC Host tasks are executed in a separate thread from the main thread which submitted the kernel and incremented reference count on objects we want to keep alive. When kernel submission occurs near the end of the script, the CPython interpreter may have begun finalization process by the time the kernel completes the execution. `PyThread_Ensure` would crash in that case. So execute the host task only if `Py_IsInitialized()`. The only testing of this scenario is to submit the kernel at the end and not call queue synchronization.
oleksandr-pavlyk
force-pushed
the
fix-crash-in-async-dec-ref
branch
from
76f0f65 to
27b6d0a
Compare
|
View rendered docs @ https://intelpython.github.io/dpctl/pulls/776/index.html |
|
@PokhodenkoSA @diptorupd Ping |
|
Deleted rendered PR docs from intelpython.github.com/dpctl, latest should be updated shortly. 🤞 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR applies the solution worked out in a toy POC
Host tasks are executed in a separate threads from
the main thread which submitted the kernel and incremented
reference counts.
When kernel submission occurs near the end of the script,
the CPython interpreter may have begun finalization process
by the time the kernel completes the execution.
PyThread_Ensurewould crash in that case. So execute the hosttask only if
Py_IsInitialized().The only testing of this scenario is to submit the kernel at
the end and not call queue synchronization.