Skip to content

Fixed typo in utility _memory_overlap. #770

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 8, 2022

Conversation

oleksandr-pavlyk
Copy link
Contributor

@oleksandr-pavlyk oleksandr-pavlyk commented Feb 7, 2022

To intervals [B1..E1) and [B2..E2) do not overlap when
E1 <= B2 || E2 <= B1 <=> B1 >= E2 || B2 >= E1.

The typo in the code was the reason why the coverage was jumping
around.

The overlap may occur only if (B1 < E2) and (B2 < E1).

@github-actions
Copy link

github-actions bot commented Feb 7, 2022

To intervals [B1..E1) and [B2..E2) do not overlap when
E1 <= B2 || E2 <= B1 <=> B1 >= E2 || B2 >= E1.

Hence the overlap may occur is (B1 < E2) and (B2 < E1).
@oleksandr-pavlyk
Copy link
Contributor Author

Failure in the internal is CI is unrelated (CMake configure failure while testing linker). Merging.

@oleksandr-pavlyk oleksandr-pavlyk merged commit 03864d0 into master Feb 8, 2022
@oleksandr-pavlyk oleksandr-pavlyk deleted the fix_typo_memory_overlap branch February 8, 2022 11:58
@github-actions
Copy link

github-actions bot commented Feb 8, 2022

Deleted rendered PR docs from intelpython.github.com/dpctl, latest should be updated shortly. 🤞

@oleksandr-pavlyk oleksandr-pavlyk changed the title Fixed type in utility _memory_overlap. Fixed typo in utility _memory_overlap. Feb 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant