Skip to content

[Refactoring] Add variables for skip decorators #684

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 14 commits into from
Dec 6, 2021
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
52 changes: 26 additions & 26 deletions dpctl/tests/test_sycl_queue_manager.py
Original file line number Diff line number Diff line change
Expand Up @@ -24,28 +24,36 @@

import dpctl


@pytest.mark.skipif(
skip_no_platform = pytest.mark.skipif(
not has_sycl_platforms(), reason="No SYCL platforms available"
)
skip_no_gpu = pytest.mark.skipif(
not has_gpu(), reason="No OpenCL GPU queues available"
)
skip_no_cpu = pytest.mark.skipif(
not has_cpu(), reason="No OpenCL CPU queues available"
)


@skip_no_platform
def test_is_in_device_context_outside_device_ctxt():
assert not dpctl.is_in_device_context()


@pytest.mark.skipif(not has_gpu(), reason="No OpenCL GPU queues available")
@skip_no_gpu
def test_is_in_device_context_inside_device_ctxt_gpu():
with dpctl.device_context("opencl:gpu:0"):
assert dpctl.is_in_device_context()


@pytest.mark.skipif(not has_cpu(), reason="No OpenCL CPU queues available")
@skip_no_cpu
def test_is_in_device_context_inside_device_ctxt_cpu():
with dpctl.device_context("opencl:cpu:0"):
assert dpctl.is_in_device_context()


@pytest.mark.skipif(not has_gpu(), reason="No OpenCL GPU queues available")
@pytest.mark.skipif(not has_cpu(), reason="No OpenCL CPU queues available")
@skip_no_gpu
@skip_no_cpu
def test_is_in_device_context_inside_nested_device_ctxt():
with dpctl.device_context("opencl:cpu:0"):
with dpctl.device_context("opencl:gpu:0"):
Expand All @@ -54,7 +62,7 @@ def test_is_in_device_context_inside_nested_device_ctxt():
assert not dpctl.is_in_device_context()


@pytest.mark.skipif(not has_cpu(), reason="No OpenCL CPU queues available")
@skip_no_cpu
def test_is_in_device_context_inside_nested_device_ctxt_cpu():
cpu = dpctl.SyclDevice("cpu")
n = cpu.max_compute_units
Expand All @@ -75,17 +83,13 @@ def test_is_in_device_context_inside_nested_device_ctxt_cpu():
assert 0 == dpctl.get_num_activated_queues()


@pytest.mark.skipif(
not has_sycl_platforms(), reason="No SYCL platforms available"
)
@skip_no_platform
def test_get_current_device_type_outside_device_ctxt():
assert dpctl.get_current_device_type() is not None


@pytest.mark.skipif(
not has_sycl_platforms(), reason="No SYCL platforms available"
)
@pytest.mark.skipif(not has_gpu(), reason="No OpenCL GPU queues available")
@skip_no_platform
@skip_no_gpu
def test_get_current_device_type_inside_device_ctxt():
assert dpctl.get_current_device_type() is not None

Expand All @@ -95,8 +99,8 @@ def test_get_current_device_type_inside_device_ctxt():
assert dpctl.get_current_device_type() is not None


@pytest.mark.skipif(not has_cpu(), reason="No OpenCL CPU queues available")
@pytest.mark.skipif(not has_gpu(), reason="No OpenCL GPU queues available")
@skip_no_cpu
@skip_no_gpu
def test_get_current_device_type_inside_nested_device_ctxt():
assert dpctl.get_current_device_type() is not None

Expand All @@ -110,15 +114,13 @@ def test_get_current_device_type_inside_nested_device_ctxt():
assert dpctl.get_current_device_type() is not None


@pytest.mark.skipif(
not has_sycl_platforms(), reason="No SYCL platforms available"
)
@skip_no_platform
def test_num_current_queues_outside_with_clause():
assert 0 == dpctl.get_num_activated_queues()


@pytest.mark.skipif(not has_gpu(), reason="No OpenCL GPU queues available")
@pytest.mark.skipif(not has_cpu(), reason="No OpenCL CPU queues available")
@skip_no_gpu
@skip_no_cpu
def test_num_current_queues_inside_with_clause():
with dpctl.device_context("opencl:cpu:0"):
assert 1 == dpctl.get_num_activated_queues()
Expand All @@ -127,8 +129,8 @@ def test_num_current_queues_inside_with_clause():
assert 0 == dpctl.get_num_activated_queues()


@pytest.mark.skipif(not has_gpu(), reason="No OpenCL GPU queues available")
@pytest.mark.skipif(not has_cpu(), reason="No OpenCL CPU queues available")
@skip_no_gpu
@skip_no_cpu
def test_num_current_queues_inside_threads():
from threading import Thread

Expand All @@ -145,9 +147,7 @@ def SessionThread():
Session2.start()


@pytest.mark.skipif(
not has_sycl_platforms(), reason="No SYCL platforms available"
)
@skip_no_platform
def test_get_current_backend():
dpctl.get_current_backend()
dpctl.get_current_device_type()
Expand Down