Update intro.rst #662
Closed
Update intro.rst #662
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Made Intro section less SYCL centric. Main goal is to avoid references to SYCL as much as possible. Otherwise we will end up teaching Python users DPC++. I understand that references to SYCL in dpctl are unavoidable but still I truly believe we can educate general Python users how to use XPU without the need to read SYCL specs
Closed
oleksandr-pavlyk
commented
Nov 8, 2021
| `Python buffer protocol <https://docs.python.org/3/c-api/buffer.html>`_ | ||
| using SYCL USM memory; making it possible to create Python objects that are | ||
| backed by SYCL USM memory. | ||
| Data Parallel Control ``dpctl`` is the Python library that controls multiple devices of a platform, features classes for |
There was a problem hiding this comment.
I think this statement is misleading. dpctl does not control devices. It allows user to specify the XPU which executes user's data-parallel code (including a call to oneMKL). It is even more fine-grained than that, but articulating that takes exposing the reader to some concepts of SYCL.
|
@oleksandr-pavlyk refer #670. I have rewritten the intro in that PR addressing some of the concerns raised here. |
|
This change has been superseded by changes in #712. |
|
@oleksandr-pavlyk I am fine with closing the PR. But, the main intro section on the landing page was not updated in #712 and remains a TODO. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@samaid
Made Intro section less SYCL centric. Main goal is to avoid references to SYCL as much as possible. Otherwise we will end up teaching Python users DPC++. I understand that references to SYCL in dpctl are unavoidable but still I truly believe we can educate general Python users how to use XPU without the need to read SYCL specs