Skip to content

Fix public CI #644

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Nov 1, 2021
Merged

Fix public CI #644

merged 3 commits into from
Nov 1, 2021

Conversation

1e-to
Copy link
Contributor

@1e-to 1e-to commented Oct 29, 2021

Fix channels priority

@1e-to 1e-to requested a review from PokhodenkoSA October 29, 2021 13:37
@coveralls
Copy link
Collaborator

coveralls commented Oct 29, 2021 •
edited
Loading

Coverage Status

Coverage remained the same at 74.511% when pulling 3a879a7 on 1e-to:ci_dpctl into 92b7ccb on IntelPython:master.

@oleksandr-pavlyk
Copy link
Contributor

Please elaborate on what problem prompts this change.

oleksandr-pavlyk
oleksandr-pavlyk reviewed Nov 1, 2021
View reviewed changes
Copy link
Contributor

@oleksandr-pavlyk oleksandr-pavlyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please squash some commits, so that this PR has 2 commits, first for the ordering of channels, and the second for the upload conditions.

@PokhodenkoSA
Copy link
Contributor

Please squash some commits, so that this PR has 2 commits, first for the ordering of channels, and the second for the upload conditions.

Agree. But better to create 2 separate PRs each with its intent.

@oleksandr-pavlyk oleksandr-pavlyk merged commit d0f13bb into IntelPython:master Nov 1, 2021
@1e-to 1e-to deleted the ci_dpctl branch November 3, 2021 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oleksandr-pavlyk oleksandr-pavlyk oleksandr-pavlyk approved these changes

@PokhodenkoSA PokhodenkoSA Awaiting requested review from PokhodenkoSA

Assignees

@1e-to 1e-to

Labels
infrastructure
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@1e-to @coveralls @oleksandr-pavlyk @PokhodenkoSA