Use safe load library functionality for Windows #598
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you @PokhodenkoSA |
Make sure to restore current directory search path in the case of an error too.
|
I have applied the change I suggested. It is the right thing to do according to documentation page of SetDllDirectory. I think this PR should graduate from the draft, and be merged. Is this code was borrowed from DAL, please communicate the proposed change to them as well. |
|
@PokhodenkoSA @oleksandr-pavlyk is this ready to proceed forward. |
|
As I understand from security team it is not a solution. Solution should rely on communication with install team. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on code from oneDAL:
https://github.com/oneapi-src/oneDAL/blob/master/cpp/daal/src/services/service_daal_load_win_dynamic_lib.cpp