Added new example of Python object exposing __sycl_usm_array_interface__ #596
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Native Pybind11-generated extension implemented Python type bound to DMatrix C++ class which allocates USM memory using sycl::usm_allocator. The Python object implements __sycl_usm_array_interface__, which allows dpctl.memory.as_usm_memory to create a view into that native USM allocation. The example.py modifies that memory from Python, and uses object's own .tolist() method to retrieve the memory using C++, demonstrating that values changed. Also added license missing headers to .cpp and .hpp files from other examples
diptorupd
reviewed
Sep 27, 2021
| { | ||
| PyObject *queue_ptr = queue.ptr(); | ||
| if (PyObject_TypeCheck(queue_ptr, &PySyclQueueType)) { | ||
| DPCTLSyclQueueRef QRef = |
There was a problem hiding this comment.
Do not we need to free the QRef?
There was a problem hiding this comment.
It appears we do not need to free QRef. The DPCTLSyclQueueRef get_queue_ref(SyclQueue q) function returns the reference stored in the Python object (https://github.com/IntelPython/dpctl/blob/master/dpctl/_sycl_queue.pyx#L691), so resources referenced by QRef are managed by the Python object itself.
DMatrix makes a copy of sycl::queue in its constructor, so it should all be good.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Native Pybind11-generated extension implemented Python type bound to
DMatrixC++ class which allocates USM memory usingsycl::usm_allocator.The Python object implements
__sycl_usm_array_interface__, which allowsdpctl.memory.as_usm_memory to create a view into that native USM allocation.
The example.py modifies that memory from Python, and uses object's own
.tolist()method to retrieve the memory using C++, demonstrating thatvalues changed.
Also added license missing headers to .cpp and .hpp files from other
examples