Skip to content

isort GH action changed and no longer accepts args input #593

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 22, 2021
Merged

isort GH action changed and no longer accepts args input #593

merged 1 commit into from
Sep 22, 2021

Conversation

oleksandr-pavlyk
Copy link
Contributor

@oleksandr-pavlyk oleksandr-pavlyk commented Sep 21, 2021 •
edited
Loading

Changed to use configuration input to specify CLI arguments.

Prompted by warning in https://github.com/IntelPython/dpctl/actions/runs/1249104763

image

@oleksandr-pavlyk
isort GH action changed and no longer accepts args input
3505031 
Changed to use configuration input to specify CLI arguments
@coveralls
Copy link
Collaborator

Coverage Status

Coverage remained the same at 72.733% when pulling 3505031 on fix-python-style-checks-workflow into 8d704db on master.

diptorupd
diptorupd approved these changes Sep 22, 2021
View reviewed changes
Copy link
Contributor

@diptorupd diptorupd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@oleksandr-pavlyk oleksandr-pavlyk merged commit ebc8b6d into master Sep 22, 2021
@oleksandr-pavlyk oleksandr-pavlyk deleted the fix-python-style-checks-workflow branch September 22, 2021 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@diptorupd diptorupd diptorupd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@oleksandr-pavlyk @coveralls @diptorupd