Skip to content

Fix/usm ndarray suai #584

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Sep 13, 2021
Merged

Fix/usm ndarray suai #584

merged 5 commits into from
Sep 13, 2021

Conversation

oleksandr-pavlyk
Copy link
Contributor

Closes #583

Sycl USM array interface should use the base pointer in the 'data'
field, rather than its own 'data'.

In [1]: import numpy as np

In [2]: import dpctl, dpctl.tensor as dpt, dpctl.memory as dpm

In [3]: X = dpt.usm_ndarray(10, dtype="|f8")
   ...: Y = np.arange(X.size, dtype=X.dtype)
   ...: X.usm_data.copy_from_host(Y.view("|u1"))

In [4]: print("X =", dpm.as_usm_memory(X).copy_to_host().view(X.dtype))
   ...: print("X[0] =", dpm.as_usm_memory(X[0]).copy_to_host().view(X.dtype))
   ...: print("X[1] =", dpm.as_usm_memory(X[1]).copy_to_host().view(X.dtype))
   ...: print("X[2] =", dpm.as_usm_memory(X[2]).copy_to_host().view(X.dtype))
X = [0. 1. 2. 3. 4. 5. 6. 7. 8. 9.]
X[0] = [0.]
X[1] = [1.]
X[2] = [2.]

Also added a test to cover this usage.

Sycl USM array interface should use the base pointer in the 'data'
field, rather than its own 'data'.

```
In [1]: import numpy as np

In [2]: import dpctl, dpctl.tensor as dpt, dpctl.memory as dpm

In [3]: X = dpt.usm_ndarray(10, dtype="|f8")
   ...: Y = np.arange(X.size, dtype=X.dtype)
   ...: X.usm_data.copy_from_host(Y.view("|u1"))

In [4]: print("X =", dpm.as_usm_memory(X).copy_to_host().view(X.dtype))
   ...: print("X[0] =", dpm.as_usm_memory(X[0]).copy_to_host().view(X.dtype))
   ...: print("X[1] =", dpm.as_usm_memory(X[1]).copy_to_host().view(X.dtype))
   ...: print("X[2] =", dpm.as_usm_memory(X[2]).copy_to_host().view(X.dtype))
X = [0. 1. 2. 3. 4. 5. 6. 7. 8. 9.]
X[0] = [0.]
X[1] = [1.]
X[2] = [2.]
```
@coveralls
Copy link
Collaborator

coveralls commented Sep 11, 2021

Coverage Status

Coverage increased (+1.0%) to 72.41% when pulling 91e4243 on fix/usm-ndarray-suai into 5f155bc on master.

@oleksandr-pavlyk oleksandr-pavlyk merged commit b97efdf into master Sep 13, 2021
@oleksandr-pavlyk oleksandr-pavlyk deleted the fix/usm-ndarray-suai branch September 13, 2021 00:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

dpm.as_usm_memory(X[i]) returns unexpected value
2 participants