Transition all Python API to use pytest over unittest, improved coverage in dpctl/memory #575
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oleksandr-pavlyk
force-pushed
the
coverage_memory
branch
from
b3db485 to
c700d83
Compare
oleksandr-pavlyk
force-pushed
the
coverage_memory
branch
from
35946d4 to
d1859c5
Compare
oleksandr-pavlyk
commented
Sep 4, 2021
oleksandr-pavlyk
commented
Sep 4, 2021
Initialized DPCTLSyclUSMRef reference variable.
oleksandr-pavlyk
force-pushed
the
coverage_memory
branch
from
c95d194 to
20d418b
Compare
1. Added a test to check MemoryConstructor(other_memory_object) 2. Add test_sycl_usm test to use copy_from_device 3. Added tests to check validation of __sycl_usm_array_interface__ in memory objects
Added tests to excercise device_context on all platforms
It appears that unittest-based tests did not participate in the coverage collection data.
oleksandr-pavlyk
force-pushed
the
coverage_memory
branch
from
6a14e3f to
ba40dab
Compare
oleksandr-pavlyk
changed the title
|
The Python API portion is now reasonably covered with test suite. Coverage of
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed all test files that used
unittestto usepytestinstead.Expanded tests to improve coverage.
Fixed several unreferenced bugs/crashes uncovered by expanded test suite.