Skip to content

Fixed __version__ test to allow for semantic versioning #569

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 2, 2021
Merged

Fixed __version__ test to allow for semantic versioning #569

merged 1 commit into from
Sep 2, 2021

Conversation

oleksandr-pavlyk
Copy link
Contributor

@oleksandr-pavlyk oleksandr-pavlyk commented Sep 2, 2021 •
edited
Loading

0.9.0dev0 is not strictly PEP-440 compliant. It follows semantic version convention. Reg-exp is relaxed to accommodate for that.

@coveralls
Copy link
Collaborator

Coverage Status

Coverage remained the same at 67.574% when pulling 24fd141 on semantic_version_re into 4eac023 on master.

@oleksandr-pavlyk oleksandr-pavlyk merged commit 67a3051 into master Sep 2, 2021
@oleksandr-pavlyk oleksandr-pavlyk deleted the semantic_version_re branch September 2, 2021 19:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PokhodenkoSA PokhodenkoSA Awaiting requested review from PokhodenkoSA

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@oleksandr-pavlyk @coveralls