Add aspect selector #558
Merged
Add aspect selector #558
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Added docstring 2. Rename arguments from "aspect_list", "deny_list" to "required_aspects", "excluded_aspects" 3. Permit aspects to be gives as Python sequences 4. If unsupported aspect is specified, AttributeError is raised as opposed to ValueError 5. ValueError is raised of the requested device is not available. 6. Tests were modified to account for possibility that function invocation may raise ValueError 7. Test was added to test that ValueError error is raised when impossible configuration is requested, like when required_aspects and excluded_aspects sets intersect.
Added a reference to where to find the list of all aspects
|
I think this is ready to go in. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the device selection function by aspects and tests to it.
Docstrings will be added in the next commit.