DPCTLSyclInterface should avoid functions that print to std::cout #542
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The stream
std::cout
that the library writes to in a function likeDPCTLDeviceMgr_PrintDeviceInfo
is not the same as Python'ssys.stdout
.It makes it difficult to verify that printed output is what should be
expected.
Used
OutputGrabber
class to try to capturestd::cout
outputs ofDPCTLSyclInterface
.The class is implemented in new
test/_redirector.py
file.The changes in this commit allow the test to pass, while ensuring
that the captured output is non-empty, but pytest must be envoked with
--capture=no
option.It works as follows:
It is all good, but
In[3]
for needed forOut[7]
to be non-empty.This is because
libDPCTLSyclInterface
does not initializestd::cout
, and In[5] writes into a differentstd::cout
that output grabber captured.