Skip to content

Add a new DPCTLEvent_WaitAndThrow function #513

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

vlad-perevezentsev
Copy link
Collaborator

@vlad-perevezentsev vlad-perevezentsev commented Jul 27, 2021

This PR adds a function DPCTLEvent_GetWaitList which waits for the event to complete and calls the asynchronous error handler

@coveralls
Copy link
Collaborator

coveralls commented Jul 27, 2021

Coverage Status

Coverage increased (+0.08%) to 64.911% when pulling f2f701f on vlad-perevezentsev:event_waitandthrow into b283185 on IntelPython:master.

@vlad-perevezentsev
Copy link
Collaborator Author

@diptorupd I added a sycl test that checks the call of the asynchronous error handler in the last commit.
Is it correct for this function?
Do I need to rewrite it via dpctl interface?
Can you tell me how better to write a test for this function?

@oleksandr-pavlyk
Copy link
Contributor

@vlad-perevezentsev please use backquotes rather than plain single quotes to delineate sycl object names.

@oleksandr-pavlyk
Copy link
Contributor

I suppose these tests will do for now, but I thought of using SYC C++ to create an event from submitting a kernel which causes a raise of an asynchronous exception to a queue with a custom handler that a side effect that a test checks for.

@oleksandr-pavlyk oleksandr-pavlyk merged commit 3fc0bf4 into IntelPython:master Aug 4, 2021
@vlad-perevezentsev vlad-perevezentsev deleted the event_waitandthrow branch August 5, 2021 07:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants