Skip to content

Add a new DPCTLEvent_Copy function #504

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 13, 2021

Conversation

vlad-perevezentsev
Copy link
Collaborator

This PR adds the DPCTLEvent_Copy function which returns a copy of the DPCTLSyclEventRef object.

@oleksandr-pavlyk
Copy link
Contributor

@vlad-perevezentsev Please add tests to dpctl-capi/tests.

@coveralls
Copy link
Collaborator

coveralls commented Jul 2, 2021

Coverage Status

Coverage increased (+0.08%) to 64.624% when pulling 9041434 on vlad-perevezentsev:sycl_event into 8c099d8 on IntelPython:master.

Copy link
Contributor

@oleksandr-pavlyk oleksandr-pavlyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use double quotes around sycl entities to help with expected rendering of the reference pages.

Also, please squash all your commits into one.

@oleksandr-pavlyk
Copy link
Contributor

The failures of Linux CI are to be expected and are not due to changes under review in this PR.

Copy link
Contributor

@oleksandr-pavlyk oleksandr-pavlyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @vlad-perevezentsev , LGTM

@oleksandr-pavlyk oleksandr-pavlyk merged commit 91e869d into IntelPython:master Jul 13, 2021
@vlad-perevezentsev vlad-perevezentsev deleted the sycl_event branch August 5, 2021 07:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants