Merge wheel changes from gold/2021 #327
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Update packages wheel deps * Make wheel version public-like * Fix package version * Remove install_requires * Append cflags and ldflags from env to build * Fix issues * Fix issue with external flags * Add wheel install description to readme * Fix formatting * Fix readme format
|
Looks good overall. My only question is what necessitated the need to read |
|
@oleksandr-pavlyk, this is required because we have global conda-build config for all built packages. It defines there variables "CFLAGS and LDFLAGS" + adds RPATH to Performance Libraries thus it is good to reuse them rather define these variables in all packages separately. |
|
@PokhodenkoSA , are you OK with the changes? |
| python -m pip install --index-url https://pypi.anaconda.org/intel/simple -extra-index-url https://pypi.org/simple dpctl | ||
| ``` | ||
| Note: dpCtl wheel package is placed on Pypi, but some of its dependencies (like Intel numpy) are in Anaconda Cloud. | ||
| That is why install command requires additional intel Pypi channel from Anaconda Cloud. |
There was a problem hiding this comment.
Suggested change
| That is why install command requires additional intel Pypi channel from Anaconda Cloud. | |
| That is why install command requires additional `intel` Pypi channel from Anaconda Cloud. |
PokhodenkoSA
approved these changes
Mar 24, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update packages wheel deps
Make wheel version public-like
Fix package version
Remove install_requires
Append cflags and ldflags from env to build
Fix issues
Fix issue with external flags
Add wheel install description to readme
Fix formatting
Fix readme format