Skip to content

[Docs] Add documentation for dpctl enums #2019

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Mar 19, 2025
Merged

[Docs] Add documentation for dpctl enums #2019

merged 7 commits into from
Mar 19, 2025

Conversation

ndgrigorian
Copy link
Collaborator

@ndgrigorian ndgrigorian commented Feb 27, 2025 •
edited by vtavana
Loading

This PR adds generated documentation for dpctl enums (i.e., device_type, backend_type, etc.)

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to an issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • Have you added documentation for your changes, if necessary?
  • Have you added your changes to the changelog?
  • If this PR is a work in progress, are you opening the PR as a draft?

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 27, 2025 •
edited
Loading

Deleted rendered PR docs from intelpython.github.com/dpctl, latest should be updated shortly. 🤞

@github-actions GitHub Actions
Copy link

Array API standard conformance tests for dpctl=0.20.0dev0=py310h93fe807_5 ran successfully.
Passed: 894
Failed: 3
Skipped: 125

@coveralls
Copy link
Collaborator

coveralls commented Feb 27, 2025 •
edited
Loading

Coverage Status

coverage: 87.677% (+0.03%) from 87.652%
when pulling 0984620 on document-dpctl-enum-types
into c3e6952 on master.

@ndgrigorian ndgrigorian force-pushed the document-dpctl-enum-types branch from c4bae75 to 7e8f2cf Compare March 14, 2025 21:39
@github-actions GitHub Actions
Copy link

Array API standard conformance tests for dpctl=0.20.0dev0=py310h93fe807_49 ran successfully.
Passed: 895
Failed: 2
Skipped: 126

@ndgrigorian ndgrigorian force-pushed the document-dpctl-enum-types branch from 7e8f2cf to cf203fa Compare March 14, 2025 23:11
@github-actions GitHub Actions
Copy link

Array API standard conformance tests for dpctl=0.20.0dev0=py310h93fe807_49 ran successfully.
Passed: 895
Failed: 2
Skipped: 126

@ndgrigorian ndgrigorian force-pushed the document-dpctl-enum-types branch from cf203fa to b87710a Compare March 15, 2025 01:57
@github-actions GitHub Actions
Copy link

Array API standard conformance tests for dpctl=0.20.0dev0=py310h93fe807_49 ran successfully.
Passed: 895
Failed: 2
Skipped: 126

@ndgrigorian ndgrigorian force-pushed the document-dpctl-enum-types branch 2 times, most recently from 48fdce3 to 61c0558 Compare March 15, 2025 03:24
@github-actions GitHub Actions
Copy link

Array API standard conformance tests for dpctl=0.20.0dev0=py310h93fe807_49 ran successfully.
Passed: 895
Failed: 2
Skipped: 126

@github-actions GitHub Actions
Copy link

Array API standard conformance tests for dpctl=0.20.0dev0=py310h93fe807_49 ran successfully.
Passed: 894
Failed: 3
Skipped: 126

@ndgrigorian
Add constants.rst for documenting dpctl constants
aa7a0b0 
Also adds custom formatting for Enums into `index.rst`
@ndgrigorian ndgrigorian force-pushed the document-dpctl-enum-types branch from 61c0558 to aa7a0b0 Compare March 15, 2025 05:20
@ndgrigorian ndgrigorian marked this pull request as ready for review March 15, 2025 05:45
@github-actions GitHub Actions
Copy link

Array API standard conformance tests for dpctl=0.20.0dev0=py310h93fe807_49 ran successfully.
Passed: 895
Failed: 2
Skipped: 126

@ndgrigorian
Reorder constants page
6879275 
This way it matches the order on the index page for `dpctl` module
@github-actions GitHub Actions
Copy link

Array API standard conformance tests for dpctl=0.20.0dev0=py310h93fe807_50 ran successfully.
Passed: 895
Failed: 2
Skipped: 126

vtavana
vtavana reviewed Mar 17, 2025
View reviewed changes
@ndgrigorian
Tweaks to examples in dpctl enum docstrings
7364932 
Remove unnecessary `print()` of the enums
@github-actions GitHub Actions
Copy link

Array API standard conformance tests for dpctl=0.20.0dev0=py310h93fe807_51 ran successfully.
Passed: 895
Failed: 2
Skipped: 126

@ndgrigorian ndgrigorian requested a review from vtavana March 18, 2025 17:50
vtavana
vtavana previously approved these changes Mar 18, 2025
View reviewed changes
@github-actions GitHub Actions
Copy link

Array API standard conformance tests for dpctl=0.20.0dev0=py310h93fe807_64 ran successfully.
Passed: 895
Failed: 2
Skipped: 126

antonwolfy
antonwolfy previously approved these changes Mar 18, 2025
View reviewed changes
@ndgrigorian ndgrigorian dismissed stale reviews from antonwolfy and vtavana via 0984620 March 18, 2025 20:09
@github-actions GitHub Actions
Copy link

Array API standard conformance tests for dpctl=0.20.0dev0=py310h93fe807_65 ran successfully.
Passed: 896
Failed: 1
Skipped: 126

@ndgrigorian ndgrigorian merged commit 59e7d4d into master Mar 19, 2025
70 of 72 checks passed
@ndgrigorian ndgrigorian deleted the document-dpctl-enum-types branch March 19, 2025 00:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vtavana vtavana vtavana approved these changes

@vlad-perevezentsev vlad-perevezentsev Awaiting requested review from vlad-perevezentsev vlad-perevezentsev is a code owner

@antonwolfy antonwolfy Awaiting requested review from antonwolfy antonwolfy is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ndgrigorian @coveralls @antonwolfy @vtavana