Updated from_dlpack docstring#1919
Merged
oleksandr-pavlyk merged 2 commits intomasterfrom Dec 3, 2024
Merged
Conversation
Closes gh-1917. The change to docstring documents that `tensor.from_dlpack` may return numpy.ndarray or tensor.usm_ndarray and stipulates when that may happen.
ndgrigorian
reviewed
Dec 3, 2024
ndgrigorian
reviewed
Dec 3, 2024
ndgrigorian
reviewed
Dec 3, 2024
antonwolfy
reviewed
Dec 3, 2024
Removed duplicated statements clarifying type of the return object from entries describing supported device keyword values to the paragraph describing the return type. Moved the note pertaining to the SYCL queue of the returned usm_ndarray there as well.
|
Deleted rendered PR docs from intelpython.github.com/dpctl, latest should be updated shortly. 🤞 |
|
Array API standard conformance tests for dpctl=0.19.0dev0=py310hdf72452_288 ran successfully. |
Collaborator
antonwolfy
approved these changes
Dec 3, 2024
Collaborator
antonwolfy
left a comment
antonwolfy
left a comment
There was a problem hiding this comment.
Thank you @oleksandr-pavlyk, LGTM!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes gh-1917.
The change to docstring documents that
tensor.from_dlpackmay returnnumpy.ndarrayortensor.usm_ndarrayand stipulates when that may happen.