Add more dlpack tests #1670
Merged
Add more dlpack tests #1670
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is done to speed-up test suite execution on multi-GPU system, like Aurora.
|
Deleted rendered PR docs from intelpython.github.com/dpctl, latest should be updated shortly. 🤞 |
|
Array API standard conformance tests for dpctl=0.17.0dev0=py310h15de555_342 ran successfully. |
ndgrigorian
reviewed
May 10, 2024
ndgrigorian
approved these changes
May 10, 2024
There was a problem hiding this comment.
This LGTM! Thank you for the addition of tests to the branch @oleksandr-pavlyk
Use F-contiguous array to both legacy and versioned capsule. Add tests for read-only array and for use of copy=True keyword for __dlpack__ call
|
Array API standard conformance tests for dpctl=0.17.0dev0=py310h15de555_345 ran successfully. |
ndgrigorian
added a commit
that referenced
this pull request
May 13, 2024
* Implements DLPack changes necessitated by memory object work
Use `ary_base` rather than `usm_ary` as manager_ctx in
DLManagedTensor struct.
Tests for DLPack use fixture to provide all devices to take advantage
of caching.
* `usm_ndarray` constructor now honors the writable flag when passed a read-only array as `buffer` argument
* Adds support for DLPack v1.0
* Uses `dlpack.h` as per DLPack v1.0 rc
* Implements `device` and `copy` keywords into `__dlpack__` and `from_dlpack`
* Implements `max_version` argument into `__dlpack__`
* Adds `DLDeviceType` enumerator to `_usmarray.pyx` for representing device types as enumerators
* Reimplements `dpt._dlpack.get_build_dlpack_version` to return a tuple of the major version and the minor version
* Adds check for major version of versioned dlpack tensor to `from_dlpack_versioned_capsule`
Also adjusts some error messages in _dlpack.pyx
* Add missing device_type enumerators from `dlpack.h`
* usm_ary -> ary_base in `to_dlpack_versioned_capsule`
* Changes to exception messages throughout _dlpack.pyx
* Versioned DLpack tensor deleter and owner tweaked
These tweaks are based on similar changes made for the managed tensor during memory work
* Updates `dpctl/tensor/include/dlpack/README.md`
DLPack version updated and new SHA for `dlpack.h` added
* Adds check that `max_version` is a 2-tuple to `__dlpack__`
* Add more dlpack tests (#1670)
* Fixture all_root_devices is to keep only 2 devices from each platform
This is done to speed-up test suite execution on multi-GPU system,
like Aurora.
* Add tests for legacy/versions capsule import-export
* Expand tests more to improve coverage
Use F-contiguous array to both legacy and versioned capsule.
Add tests for read-only array and for use of copy=True keyword
for __dlpack__ call
* Test the writable flag of a usm_ndarray from read-only DLPack capsule
Also adds a test checking for the writable flag of a usm_ndarray constructed with a read-only usm_ndarray as the buffer
Removes some commented out `flags` checks from `test_meshgrid2`. These checks were malformed, as `dpt.meshgrid` returns a non-contiguous view in the test.
* Factor out device-id computation
Reuse that in both capsule producers to avoid code duplication
* Reuse get parent device ordinal id routine (#1672)
* Reused get_parent_device_ordinal_id routine
* test_legacy_dlpack_capsule uses 4 kinds of dtype
Added test to use non-default copy keyword, and non-default device keyword
argument.
* Adds more DLPack tests to improve coverage
* Adds a test for boolean arrays in test_legacy_dlpack_capsule
* DLPack tests for `copy` and `stream` kwargs in `__dlpack__`
---------
Co-authored-by: Oleksandr Pavlyk <oleksandr.pavlyk@intel.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds tests to improve coverage in gh-1667