Changes test_func_order tests for some unary functions#1658
Merged
oleksandr-pavlyk merged 1 commit intomasterfrom May 2, 2024
Merged
Changes test_func_order tests for some unary functions#1658oleksandr-pavlyk merged 1 commit intomasterfrom
oleksandr-pavlyk merged 1 commit intomasterfrom
Conversation
The change is to iterate over permutations first, doing some work that does not depend on the order, and then iterate over orders. This should save doing some computations 4 times (once for each order), now only done once.
|
Deleted rendered PR docs from intelpython.github.com/dpctl, latest should be updated shortly. 🤞 |
Collaborator
|
Array API standard conformance tests for dpctl=0.17.0dev0=py310h15de555_318 ran successfully. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The change is to iterate over permutations first, doing some work that does not depend on the order, and then iterate over orders.
This should save doing some computations 4 times (once for each order), now only done once.
The change shaves 4 seconds off of execution of entire test suite on CPU device (from 5 minutes 6 seconds to 5 minutes and 2 seconds).