Skip to content

Changes test_func_order tests for some unary functions#1658

Merged
oleksandr-pavlyk merged 1 commit intomasterfrom
optimize_tests_order
May 2, 2024
Merged

Changes test_func_order tests for some unary functions#1658
oleksandr-pavlyk merged 1 commit intomasterfrom
optimize_tests_order

Conversation

@oleksandr-pavlyk
Copy link
Contributor

The change is to iterate over permutations first, doing some work that does not depend on the order, and then iterate over orders.

This should save doing some computations 4 times (once for each order), now only done once.

The change shaves 4 seconds off of execution of entire test suite on CPU device (from 5 minutes 6 seconds to 5 minutes and 2 seconds).

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to an issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • If this PR is a work in progress, are you opening the PR as a draft?

The change is to iterate over permutations first, doing
some work that does not depend on the order, and then iterate
over orders.

This should save doing some computations 4 times (once for each
order), now only done once.
@github-actions
Copy link

github-actions bot commented May 1, 2024

Deleted rendered PR docs from intelpython.github.com/dpctl, latest should be updated shortly. 🤞

@coveralls
Copy link
Collaborator

Coverage Status

coverage: 87.892%. remained the same
when pulling cda4574 on optimize_tests_order
into 6ae9f3d on master.

@github-actions
Copy link

github-actions bot commented May 1, 2024

Array API standard conformance tests for dpctl=0.17.0dev0=py310h15de555_318 ran successfully.
Passed: 870
Failed: 8
Skipped: 92

Copy link
Collaborator

@ndgrigorian ndgrigorian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@oleksandr-pavlyk oleksandr-pavlyk merged commit 0df3bec into master May 2, 2024
@oleksandr-pavlyk oleksandr-pavlyk deleted the optimize_tests_order branch May 2, 2024 01:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants