-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implements out
keyword for where
and reductions and order
keyword for where
#1643
Conversation
Deleted rendered PR docs from intelpython.github.com/dpctl, latest should be updated shortly. 🤞 |
Array API standard conformance tests for dpctl=0.17.0dev0=py310h15de555_243 ran successfully. |
Overall, good change, thanks @ndgrigorian ! Love the increase in coverage |
… paths for zero-size arrays This prevents possible edge cases where an array with a non-zero number of elements could be allocated prior to an error being thrown for a reduction being performed over a size-zero axis
Avoids a call to permute_dims in reductions when `axis=None` Make reduction tests more efficient by reusing an array of zeros rather than reconstructing
faa0e69
to
16b631f
Compare
Array API standard conformance tests for dpctl=0.17.0dev0=py310h15de555_308 ran successfully. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you @ndgrigorian !
This pull request proposes building on the set of functions supporting the
out
keyword in dpctl. Specifically, this pull request implements this keyword in all reductions (e.g.,sum
,max
,argmax
) andwhere
. This paves the way for statistical functions to support the keyword, and may make some function calls more efficient.This pull request also implements the
order
keyword inwhere
, now defaulting toorder="K"
behavior rather thanorder="A"
.