-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Output of searchsorted must always have default indexing data type #1598
Output of searchsorted must always have default indexing data type #1598
Conversation
This is mandated by array API specification
Deleted rendered PR docs from intelpython.github.com/dpctl, latest should be updated shortly. 🤞 |
Array API standard conformance tests for dpctl=0.17.0dev0=py310h15de555_139 ran successfully. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch @oleksandr-pavlyk , I missed it when I read the spec. LGTM!
@antonwolfy pointed this out while running |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @oleksandr-pavlyk, the tests work fine now,
Output of
tensor.searchsorted
must always have default indexing data type.This is mandated by array API specification