Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Output of searchsorted must always have default indexing data type #1598

Merged
merged 2 commits into from
Mar 20, 2024

Conversation

oleksandr-pavlyk
Copy link
Collaborator

Output of tensor.searchsorted must always have default indexing data type.

This is mandated by array API specification

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to an issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • If this PR is a work in progress, are you opening the PR as a draft?

Copy link

github-actions bot commented Mar 19, 2024

Deleted rendered PR docs from intelpython.github.com/dpctl, latest should be updated shortly. 🤞

@coveralls
Copy link
Collaborator

Coverage Status

coverage: 87.832%. remained the same
when pulling f92bfc4 on searchsorted-always-return-indexing-type
into f3caaa1 on master.

Copy link

Array API standard conformance tests for dpctl=0.17.0dev0=py310h15de555_139 ran successfully.
Passed: 906
Failed: 0
Skipped: 94

Copy link
Collaborator

@ndgrigorian ndgrigorian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch @oleksandr-pavlyk , I missed it when I read the spec. LGTM!

@oleksandr-pavlyk
Copy link
Collaborator Author

Good catch @oleksandr-pavlyk

@antonwolfy pointed this out while running dpnp test suite.

Copy link
Collaborator

@antonwolfy antonwolfy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @oleksandr-pavlyk, the tests work fine now,

@oleksandr-pavlyk oleksandr-pavlyk merged commit ccb64a5 into master Mar 20, 2024
46 of 48 checks passed
@oleksandr-pavlyk oleksandr-pavlyk deleted the searchsorted-always-return-indexing-type branch March 20, 2024 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants