Avoid superfluous copy of dpctl_capi struct #1595
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR eliminates superfluous copying of
dpctl_capi
instance, even if it is later eliminated by the compiler.The copying would necessary in
static dpctl_capi api = lookup()
line, sincelookup
returnsdpctl_capi
instance by value.The change is to make it return a reference.
Since
dpctl_capi
is a singleton, this change only eliminates a single copy, so consider it a technical debt cleanup change.The PR also adds a default move assignment operator for
dpctl_capi
.