Restore using -fno-sycl-footer option for coverage collection #1572
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As pointed out by @diptorupd lcov file no longer contain data for libsyclinterface cpp files. Restoring this option recovers those locally.
|
Deleted rendered PR docs from intelpython.github.com/dpctl, latest should be updated shortly. 🤞 |
Collaborator
diptorupd
approved these changes
Feb 29, 2024
Contributor
diptorupd
left a comment
diptorupd
left a comment
There was a problem hiding this comment.
Thank you Sasha! The change helps me a lot in writing the test cases for my PR.
|
Array API standard conformance tests for dpctl=0.17.0dev0=py310h15de555_43 ran successfully. |
ndgrigorian
approved these changes
Feb 29, 2024
oleksandr-pavlyk
deleted the
restore-no-sycl-footer-option-for-libsyclinterface
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As pointed out by @diptorupd "dpctl.lcov" file no longer contains data for
libsyclinterface's ".cpp" files.Restoring this option recovers those locally.