Fix bad order=K code logic in tensor.asarray #1351
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
View rendered docs @ https://intelpython.github.io/dpctl/pulls/1351/index.html |
|
Array API standard conformance tests for dpctl=0.14.6dev3=py310h7bf5fec_7 ran successfully. |
ndgrigorian
reviewed
Aug 16, 2023
oleksandr-pavlyk
force-pushed
the
fix-gh-1350
branch
from
5a86345 to
43b9c06
Compare
|
Array API standard conformance tests for dpctl=0.14.6dev3=py310ha25a700_13 ran successfully. |
ndgrigorian
approved these changes
Aug 17, 2023
antonwolfy
approved these changes
Aug 17, 2023
There was a problem hiding this comment.
The issue is resolved, no new problem observed by dpnp tests scope. Thank you @oleksandr-pavlyk !
|
Deleted rendered PR docs from intelpython.github.com/dpctl, latest should be updated shortly. 🤞 |
|
Array API standard conformance tests for dpctl=0.14.6dev3=py310ha25a700_13 ran successfully. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes gh-1350
dpctl.tensor.asarrayimplementation oforder='K'keyword processing was replaced with call to tested_empty_like_orderKutility to fix the issue reported in gh-1350.Few routines had to be shuffled to avoid import failure due to circular import dependencies.